Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Bump chrome driver version in PR check workflow #2186

Merged
merged 1 commit into from
Aug 23, 2022
Merged

Bump chrome driver version in PR check workflow #2186

merged 1 commit into from
Aug 23, 2022

Conversation

zhongnansu
Copy link
Member

@zhongnansu zhongnansu commented Aug 23, 2022 •
edited by kavilla
Loading

Signed-off-by: Su [email protected]

Description

Bump chrome driver version to 1.4

Issues Resolved

│ warn Failure while creating webdriver instance
     │ warn { SessionNotCreatedError: session not created: This version of ChromeDriver only supports Chrome version 102
     │      Current browser version is 104.0.5112.79 with binary path /usr/bin/google-chrome
     │          at Object.throwDecodedError (/home/runner/work/OpenSearch-Dashboards/OpenSearch-Dashboards/node_modules/selenium-webdriver/lib/error.js:550:15)
     │          at parseHttpResponse (/home/runner/work/OpenSearch-Dashboards/OpenSearch-Dashboards/node_modules/selenium-webdriver/lib/http.js:565:13)
     │          at Executor.execute (/home/runner/work/OpenSearch-Dashboards/OpenSearch-Dashboards/node_modules/selenium-webdriver/lib/http.js:491:26)
     │          at process._tickCallback (internal/process/next_tick.js:68:7)
     │        name: 'SessionNotCreatedError',

Check List

  • New functionality includes testing.
    • All tests pass
      • yarn test:jest
      • yarn test:jest_integration
      • yarn test:ftr
  • New functionality has been documented.
  • Commits are signed per the DCO using --signoff

@ananzh ananzh requested review from ananzh and kavilla August 23, 2022 17:02
@kavilla
Copy link
Member

kavilla commented Aug 23, 2022

Don't need backporting to 2.x branches since we use a docker image to run the CI on.

@kavilla kavilla merged commit f2e9afa into opensearch-project:1.x Aug 23, 2022
@opensearch-trigger-bot
Copy link
Contributor

The backport to 1.x failed:

The process '/usr/bin/git' failed with exit code 1

To backport manually, run these commands in your terminal:

# Fetch latest updates from GitHub
git fetch
# Create a new working tree
git worktree add .worktrees/backport-1.x 1.x
# Navigate to the new working tree
cd .worktrees/backport-1.x
# Create a new branch
git switch --create backport/backport-2186-to-1.x
# Cherry-pick the merged commit of this pull request and resolve the conflicts
git cherry-pick -x --mainline 1 f2e9afa0c6088d7ca0e5f67d01c11179a30d4128
# Push it to GitHub
git push --set-upstream origin backport/backport-2186-to-1.x
# Go back to the original working tree
cd ../..
# Delete the working tree
git worktree remove .worktrees/backport-1.x

Then, create a pull request where the base branch is 1.x and the compare/head branch is backport/backport-2186-to-1.x.

opensearch-trigger-bot bot pushed a commit that referenced this pull request Aug 23, 2022
@zhongnansu @github-actions
Bump chrome version in PR check workflow (#2186)
5b7da11 
Bump chrome driver version to 104 for github actions

Signed-off-by: Su <[email protected]>
(cherry picked from commit f2e9afa)
@opensearch-trigger-bot opensearch-trigger-bot bot mentioned this pull request Aug 23, 2022
Merged
zhongnansu added a commit that referenced this pull request Aug 23, 2022
@opensearch-trigger-bot @zhongnansu
Bump chrome version in PR check workflow (#2186) (#2190)
b7ef826 
Bump chrome driver version to 104 for github actions

Signed-off-by: Su <[email protected]>
(cherry picked from commit f2e9afa)

Co-authored-by: Zhongnan Su <[email protected]>
@kristenTian kristenTian mentioned this pull request Oct 18, 2022
Merged
8 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kavilla kavilla kavilla approved these changes

@ananzh ananzh ananzh approved these changes

@AMoo-Miki AMoo-Miki Awaiting requested review from AMoo-Miki AMoo-Miki is a code owner

Assignees
No one assigned
Labels
backport 1.3 ci v1.3.6
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@zhongnansu @kavilla @ananzh